Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warp, warp-tls: Export functions to serve applications over existing connections #1007

Closed
wants to merge 5 commits into from
Closed

warp, warp-tls: Export functions to serve applications over existing connections #1007

wants to merge 5 commits into from

Conversation

dpwiz
Copy link
Contributor

@dpwiz dpwiz commented Sep 22, 2024 •
edited
Loading

For #1006

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

@dpwiz dpwiz marked this pull request as ready for review September 22, 2024 18:26
@kazu-yamamoto kazu-yamamoto self-requested a review September 24, 2024 01:48
kazu-yamamoto
kazu-yamamoto approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@kazu-yamamoto kazu-yamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections though I don't understand the purpose completely.

kazu-yamamoto added a commit to kazu-yamamoto/wai that referenced this pull request Sep 24, 2024
@kazu-yamamoto
Merge PR yesodweb#1007
ec5e017
@kazu-yamamoto
Copy link
Contributor

Rebased and merged.
Thank you for your contribution.
If you wish, I will make new releases.

@dpwiz
Copy link
Contributor Author

dpwiz commented Sep 24, 2024

No objections though I don't understand the purpose completely.

That's one of the legs for the TLS virtual hosts effort (with the other being that SNI thing).

If you wish, I will make new releases.

Thanks! I'll be glad, but it isn't quite urgent.

@kazu-yamamoto
Copy link
Contributor

New versions have been released.

@dpwiz dpwiz deleted the serve-connection branch September 25, 2024 13:51
@Vlix Vlix mentioned this pull request Oct 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazu-yamamoto kazu-yamamoto kazu-yamamoto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dpwiz @kazu-yamamoto